Inconsistent nginx log_format default between Omnibus and install from source

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

The default nginx log_format setting are inconsistent between that used in Ombnibus gitlab.rb and the install from source nginx configuration file found at lib/support/nginx/gitlab and lib/support/nginx/gitlab-ssl. The gitlab.rb file has $gzip_ratio while the lib/support/gitlab and lib/support/gitlab-ssl files ommit it.

gitlab.rb

# nginx['log_format'] = '$remote_addr - $remote_user [$time_local] "$request_method $filtered_request_uri $server_protocol" $status $body_bytes_sent "$filtered_http_referer" "$http_user_agent" $gzip_ratio'

lib/support/gitlab

log_format gitlab_access '$remote_addr - $remote_user [$time_local] "$request_method $gitlab_filtered_request_uri $server_protocol" $status $body_bytes_sent "$gitlab_filtered_http_referer" "$http_user_agent"';

Documentation at https://docs.gitlab.com/ee/administration/logs/#nginx-logs does not match the gitlab.rb default setting.

Note that gzip compression is turned off in the lib/support/gitlab(-ssl) so this may be intentional, but, at a minimum, the docs need to be updated to reflect what is used in gitlab.rb.

Related

Edited by 🤖 GitLab Bot 🤖