Follow-up from "Set default PAT expiration to 365 days from now"

The following discussions from !120213 (merged) should be addressed:

• @terrichu started a discussion:

  suggestion (non-blocking): let_it_be might be a little faster, but I think it's most helpful with complex data (like projects) so this is non-blocking

• @terrichu started a discussion:

  question: should this be 'project bot membership does not expire'? (and also should https://gitlab.com/gitlab-org/gitlab/-/blob/788161af4ba189f9035136a16f2e8d80db261bc5/spec/services/resource_access_tokens/create_service_spec.rb#L204 be project bot membership expires?

• @dblessing started a discussion:

  Suggestion: Ideally should this translated string use the constant value in case we change it later?

        errors.add(:expires_at, format(_("must expire in %{expiry} days"), expiry: MAX_PERSONAL_ACCESS_TOKEN_LIFETIME_IN_DAYS)