Combine sign-in appearances settings
There are three different options that change the appearance of the sign-in pages (some of the options below affects the sign-up and trial_registration pages too):
- [1] Admin > Settings > Appearance > Sign in/Sign up pages > Description
- [2] Admin > Settings > Preferences > Sign-in and Help page > Additional text to show on the sign-in page
- [3] Admin > Settings > General > Sign-in restriction > Sign-in text
It is confusing that similar settings appear under three different sections of the Admin > Settings.
Below, @leipert suggests to combine options #1 and #2 together under Admin > Settings > Appearance > Sign in/Sign up pages > Description and deprecate #2.
@eduardosanz suggest to do this after the restyle_login_page
feature flag is removed. That will simplify the process, because the order of appearance is different in the old and new styles. Order on the old style: 1, 3, 2 (in left column). Order in the new style: 1, 2 (left column), 3 (right column below the sign-in box).
The following discussion from !118957 (merged) should be addressed:
-
@leipert started a discussion: (+7 comments) @eduardosanz I was super confused what this does. I first thought it is something like the errors, but it turns out we not only have:
- [1] Admin > Settings > Appearance > Sign in/Sign up pages > Description
but also
- [2] Admin > Settings > Preferences > Sign-in and Help page > Additional text to show on the sign-in page
I really cannot tell a big difference between the two, maybe we should deprecate one in favor of the other? The latter seems to be EE only as well
🙈
That being said, because the latter also limits it's own width, the layout looks weird.
Before After What's also weird, if only [2] is set, we still have a one-column layout:
cc/ @jannik_lehmann as you might have more context.