[Feature Flag] Cleanup deployments_raise_updated_at_inefficient_error and corresponding override

Summary

This issue is to cleanup the deployments_raise_updated_at_inefficient_error and deployments_raise_updated_at_inefficient_error_override feature flags, after the feature flag has been enabled by default for an appropriate amount of time in production.

This feature introduces a breaking change in the Deployments API #328500 (closed) that was introduced in the major version %16.0. With the Feature Flag enabled, a call to the Deployments API that uses the updated_at filter without the updated_at ordering will result in a 400 (Bad Request) - Inefficient Query Error.

We also introduced an override Feature Flag !120066 (merged) in order to revert to the old behavior that accepts inefficient queries. The reason for this is to give users that run into a large volume of errors some time to adjust their API calls.

This is not meant to be a long-lived Feature Flag.

We need to drop both Feature Flags on %16.1. deployments_raise_updated_at_inefficient_error is already enabled by default on gprd. We know it's safe to drop if deployments_raise_updated_at_inefficient_error_override is disabled for all actors. As of time of writing, the override is disabled for everything, but it is best to double check before starting the work on this.

Owners

Stakeholders

N/A

Expectations

What might happen if this goes wrong?

Cleaning up the feature flag

  • Create a merge request to remove <feature-flag-name> feature flag. Ask for review and merge it.
    • Remove all references to the feature flag from the codebase.
    • Remove the YAML definitions for the feature from the repository.
    • Create a changelog entry.
  • Ensure that the cleanup MR has been deployed to both production and canary. If the merge request was deployed before the code cutoff, the feature can be officially announced in a release blog post.
    • /chatops run auto_deploy status <merge-commit-of-cleanup-mr>
  • Close the feature issue to indicate the feature will be released in the current milestone.
  • If not already done, clean up the feature flag from all environments by running these chatops command in #production channel:
    • /chatops run feature delete <feature-flag-name> --dev
    • /chatops run feature delete <feature-flag-name> --staging
    • /chatops run feature delete <feature-flag-name>
  • Close this rollout issue.
Edited by Pam Artiaga