Custom email notification event settings not disabling correctly
Summary
Disabling the "Push to merge request" setting in the notification settings is not working.
Steps to reproduce
- Install GitLab and configure with email notifications enabled
- Create a project and a merge request (make sure the project and group notification settings are set to Global)
- Go to your User Settings -> Notifications
- Press the dropdown for Global notification level and select Custom
- In the pop-up, uncheck "Push to merge request"
- Push a commit to the merge request from step 2
- You should get an email from the server (this is the bug)
What is the current bug behavior?
Getting email notifications for a specific type when it is turned off.
What is the expected correct behavior?
I should not be getting emails for pushes to merge requests.
Relevant logs
N/A
Details of package version
I just updated from 15.10.2, but the issue is still present.
Provide the package version installation details
un gitlab-ce (no description available) ii gitlab-ee 15.11.1-ee.0 amd64 GitLab Enterprise Edition (including NGINX, Postgres, Redis) un gitlab-fips (no description available)
Environment details
- Operating System: Linux 5.10.0-21-amd64 omnibus-gitlab#1 (closed) SMP Debian 5.10.162-1 (2023-01-21) x86_64 GNU/Linux
- Installation Target, remove incorrect values:
- VM: KVM/QEMU Debian guest on RHEL 8 host
- Installation Type, remove incorrect values:
- New Installation
- Upgrade from version 15.10.2 (see Details of package version)
- Is there any other software running on the machine: No, pretty clean VM.
- Is this a single or multiple node installation? No
- Resources
- CPU: 2 cores shared from host: Ryzen 9 5950X
- Memory total: 4GB shared from host
- MiB Mem : 3835.0 total, 243.4 free, 2543.7 used
Configuration details
Provide the relevant sections of `/etc/gitlab/gitlab.rb`
external_url 'https://IP.ADDRESS' gitlab_rails['smtp_enable'] = true gitlab_rails['smtp_address'] = "smtp.office365.com" gitlab_rails['smtp_port'] = 587 gitlab_rails['smtp_user_name'] = "EMAIL" gitlab_rails['smtp_password'] = "PASSWORD" gitlab_rails['smtp_domain'] = "DOMAIN" gitlab_rails['smtp_authentication'] = "login" gitlab_rails['smtp_enable_starttls_auto'] = true gitlab_rails['smtp_openssl_verify_mode'] = 'peer' gitlab_rails['gitlab_email_from'] = 'EMAIL' puma['worker_processes'] = 0 # 2 sidekiq['max_concurrency'] = 10 nginx['ssl_certificate'] = "/etc/gitlab/ssl/goliath-gitlab.crt" nginx['ssl_certificate_key'] = "/etc/gitlab/ssl/goliath-gitlab.key" prometheus['enable'] = false gitaly['ruby_max_rss'] = 200000000 # RSS threshold in bytes for triggering a gitaly-ruby restart gitaly['concurrency'] = [ { 'rpc' => "/gitaly.SmartHTTPService/PostReceivePack", 'max_per_repo' => 3 }, { 'rpc' => "/gitaly.SSHService/SSHUploadPack", 'max_per_repo' => 3 } ] letsencrypt['enable'] = false