Audit dropdown in policy area to make sure they use the new dropdown correctly
Based on the Slack discussion and New updated on pajama documents, I need an audit on current policy usage of dropdowns, I updated most I found need to be updated, if I am not capture everything, please follow it should follow the New updated on pajama documents, below are what relevant for policy.
Scan result policy(aka MR approval policy) | Scan execution policy |
---|---|
- If it is a single selection & needs ONLY ONE action, ex,
Select all
-> it will be an action on the top of the list - If it is multi-selection & needs ONLY ONE action, ex,
Select all
-> it will be an action on the top of the list - If it is multi-selection & needs MORE THAN ONE action, ex "all branches" and "all protected" branches -> two steps dropdown
- If it is multi-selection & needs options instead of actions,
Any branches
-> wait for the new feature supported in the dropdown to enable the single select option in the multi-select option - Header should follow the rules below
- Single selection -> Choose a XXX or none
- Multiple selections -> Select XXXs
Implementation
-
frontend Look at the above audit screenshots and update their designs
-
Update all instances of a dropdown without a Select all
option to have aSelect all
option in the header -
Update all instances of a dropdown with a single Select all
option in the footer to have theSelect all
option in the header -
Update all instances of a dropdown with multiple Select all
options in the footer to have two dropdowns instead
-
Edited by Camellia X Yang