Verify that hash storage works in project export/import and other cases
In gitlab-org/gitlab-ce!15400, doing a quick audit of places where we use full_path
and disk_path
(as well as File.join
), I noticed a few places where we might need to check:
-
Protect against transferring projects in hash storage in
Projects::TransferService
?app/services/projects/transfer_service.rb: @new_path = File.join(@new_namespace.try(:full_path) || '', project.path)
-
Check that the GitLab import/exporter works properly. What happens if there is a project ID already for that path?
lib/gitlab/import_export/importer.rb: File.join(@project.namespace.full_path, @project.path)