Skip to content

[Feature flag] Cleanup branch_rules

Summary

This issue is to cleanup the branch_rules feature flag, after the feature flag has been enabled by default for an appropriate amount of time in production.

Note, the feature flag has already been enabled by default as part of #363170 (closed)

Owners

  • Team: groupsource code
  • Most appropriate slack channel to reach out to: #g_create_source-code
  • Best individual to reach out to: @jerasmus @andr3 @vyaklushin
  • PM: Torsten Linz (@tlinz)

Expectations

What might happen if this goes wrong?

  1. The Branch rules section under settings is not working as expected.
  2. The Branch rules page is not working as expected.
  3. Branch rules not working as expected after configuring with the new Branch rules feature.

Cleaning up the feature flag

  • Create a merge request to remove branch_rules feature flag. Ask for review and merge it.
    • Remove all references to the feature flag from the codebase.
    • Remove the YAML definitions for the feature from the repository.
    • Create a changelog entry.
  • Ensure that the cleanup MR has been deployed to both production and canary. If the merge request was deployed before the code cutoff, the feature can be officially announced in a release blog post.
    • /chatops run auto_deploy status <merge-commit-of-cleanup-mr>
  • Close the feature issue to indicate the feature will be released in the current milestone.
  • If not already done, clean up the feature flag from all environments by running these chatops command in #production channel:
    • /chatops run feature delete <feature-flag-name> --dev
    • /chatops run feature delete <feature-flag-name> --staging
    • /chatops run feature delete <feature-flag-name>
  • Close this rollout issue.
Edited by Joe Woodward