Approval button missing for some MRs since 15.5.9 upgrade
Summary
Customer recently upgraded from v14.10.5 to v15.5.9. Following this upgrade, merge requests in a project with an approval rule in place that allows members of a particular group to approve MRs no longer show the approval button for members of that group even though a user can see their own gravatar on the page as a user eligible to approve. Merge requests in the same project with the same rule had the approval button visible for members of the group prior to the upgrade.
Adding a user as a direct member of the project instead of having permission inherited from a group allows the approval to function, but this is a workaround and is not ideal to apply at scale.
Steps to reproduce
In the client instance project:
- Create a merge request in the project in question.
- Have a user who is a member of the group listed in the project's "default" approval rule as able to approve view the merge request.
- The approval button will not appear.
What is the current bug behavior?
The approval button on a merge request will not appear for a user listed as eligible unless they are added as a direct member of the project.
What is the expected correct behavior?
The approval button will appear for eligible approvers.
Relevant logs and/or screenshots
Logs and screenshots contain internal user information. They're all available in the ZenDesk Ticket (internal only) and I can provide them for any assignees with context if needed.
Possible fixes
It looks like the change happened with issue 255981 that changed subgroup approval rules. Toggling the feature flag doesn't change the behavior though. Only adding the user as a direct member of the project allows the approval to work.