Follow-up to add Runner approvers for Runner Rails domain code

The merged MR !115481 (merged) has:

  • @gitlab-org/maintainers/cicd-verify contains 8 BE maintainers - These are the default approvers for all files in Verify section.
  • @gitlab-org/ci-cd/verify/frontend contains 7 FE engineers and it's used as approver list for Verify FE files.
    • At the end of Verify section we override the default owners with FE reviewers for specific FE-owned file paths.
    • Note that @mrincon is included in this list.

Tasks for a follow-up MR:

  • Create a user list for Runner approvers, for example @gitlab-org/ci-cd/runner-fleet-team (feel free to rename this)
  • We could even combine the approvers as @gitlab-org/maintainers/cicd-verify @gitlab-org/ci-cd/runner-fleet-team to have a larger pool.
  • Add these file paths at the end of the Verify section (or create a separate Runner section in CODEOWNERS) and set the right approvers for these paths, here are the filters for the files that are important to keep track of for backend Category:Runner Fleet :
Backend filters for fleet management
app/controllers/admin/runner*.rb
app/controllers/concerns/runner*.rb
app/controllers/groups/runner*.rb
app/controllers/projects/runner*.rb
app/controllers/runner*.rb
app/finders/ci/runner*.rb
app/graphql/mutations/ci/runner/
app/graphql/resolvers/ci/*_runners_resolver.rb
app/graphql/resolvers/ci/runner*.rb
app/graphql/types/ci/runner_*.rb
app/graphql/types/namespace/shared_runners_setting_enum.rb
app/graphql/types/permission_types/ci/runner*.rb
app/models/ci/build_runner_session.rb
app/models/ci/runner*.rb
app/models/concerns/ci/has_runner_executor.rb
app/models/concerns/runner*.rb
app/models/preloaders/runner*.rb
app/policies/ci/runner*.rb
app/presenters/ci/runner_*.rb
app/serializers/runner*.rb
app/services/ci/runners/
app/workers/ci/runners/
db/docs/ci_runner*.yml
ee/app/controllers/ee/admin/runner*.rb
ee/app/controllers/ee/groups/runner*.rb
ee/app/graphql/ee/mutations/ci/runner/
ee/app/graphql/ee/types/ci/runner*.rb
ee/app/graphql/resolvers/ci/runner*.rb
ee/app/models/ee/ci/runner*.rb
ee/app/policies/ee/ci/runner*.rb
ee/app/services/audit_events/*runner*.rb
ee/app/services/ci/runners/
ee/app/services/ee/ci/runners/
ee/app/workers/ci/runners/
ee/lib/ee/api/ci/helpers/runner*.rb
ee/spec/graphql/ee/mutations/ci/runner/
ee/spec/graphql/resolvers/ci/runner*.rb
ee/spec/graphql/types/ci/runner*.rb
ee/spec/models/ee/ci/runner*.rb
ee/spec/policies/ee/ci/runner*.rb
ee/spec/requests/api/graphql/ci/runner*.rb
ee/spec/services/audit_events/*runner*.rb
ee/spec/services/ci/runners/
ee/spec/workers/ci/runners/
lib/api/ci/helpers/runner*.rb
lib/api/ci/runner*.rb
lib/api/entities/ci/runner*.rb
lib/gitlab/audit/ci_runner_token_author.rb
lib/gitlab/ci/runner*.rb
lib/gitlab/seeders/ci/runner/
lib/tasks/gitlab/seed/runner_fleet.rake
spec/factories/ci/runner*.rb
spec/finders/ci/runner*.rb
spec/graphql/mutations/ci/runner/
spec/graphql/resolvers/ci/*runner*.rb
spec/graphql/types/ci/runner*.rb
spec/graphql/types/permission_types/ci/runner*.rb
spec/lib/gitlab/audit/ci_runner_token_author_spec.rb
spec/lib/gitlab/ci/runner*.rb
spec/lib/gitlab/seeders/ci/runner/
spec/models/ci/runner*.rb
spec/models/concerns/runners*.rb
spec/models/preloaders/runner*.rb
spec/requests/api/ci/runner/
spec/requests/api/graphql/ci/runner*.rb
spec/requests/api/graphql/mutations/ci/runner/
spec/requests/api/graphql/mutations/ci/runners_registration_token/
spec/requests/api/graphql/project/runner*.rb
spec/services/ci/runners/
spec/support/helpers/runner*.rb
spec/support/shared_contexts/graphql/resolvers/runner*.rb
spec/support/shared_examples/features/runner*.rb
spec/support/shared_examples/lib/api/ci/runner*.rb
spec/tasks/gitlab/seed/runner_fleet_*.rb
spec/workers/ci/runners/
Edited by Pedro Pombeiro