Skip to content

Prepare removal of License-Check feature

Why are we doing this work

We want to prepare MRs for both frontend and backend to remove the License-Check feature in %16.0. As removing the feature requires checking in multiple places we want to make sure these changes are well-tested before %16.0.

Relevant links

Non-functional requirements

  • Documentation: Documentation is updated with removing mentions about this feature and updated screens where this feature could be listed
  • Feature flag: Feature flag for License Approval Policies (&8092 - closed) is removed
  • Performance:
  • Testing: frontend and backend and documentation do not mention the License-Check feature and mention License Approval Policies instead.

Implementation plan

  • backend: Refer to the 397067-prepare-removal-of-license-check-feature branch
  • backend Prepare database migration to remove records from software_license_policies that has scan_result_policy_id as nil
  • backend License Scanning Template is out of scope for this issue. This removal will be managed by groupcomposition analysis.
  • frontend License-Check should be removed
    • /-/settings/merge_requests License-Check specific code in the Merge Request Approvals widget that is shown by default should be removed
    • /-/merge_requests/:id Approval widget License-Check Approval-specific code should be removed
    • update docs
  • frontend License Compliance Policies (see screenshots)
    • /-/licenses#policies tab should be deleted
    • /-/merge_requests/:id License Compliance Widget Manage License button should be deleted
    • /-/pipelines/:id/licenses tab Manage Licenses button needs to point to /-/security/policies
    • update docs
License Check screenshots
Page Screenshot
/-/settings/merge_requests License-Check specific code in the Merge Request Approvals widget license_check_MR_setting
/-/merge_requests/:id License-Check Approval that is shown by default license_check_MR_approval
License Compliance screenshots
Page Screenshot
/-/merge_requests/:id License Compliance Widget license_compliance_MR_widget_-_manage_button
/-/licenses#policies page license_compliance_page_-_correct_2
/-/licenses page tabs license_compliance_pipeline_tab_-_manage_button

Verification steps

Edited by Marcos Rocha