Rename security dashboard graphql error message
The graphql error alert shown to users on the group or instance security dashboard can be improved. See original discussion.
Change it from:
Error fetching the vulnerabilities over time. Please check your network connection and try again.
to:
Failed to retrieve the vulnerability data. Please refresh the page.
from @rdickenson comment:
Reasoning
- In the current message, the phrase "vulnerabilities over time" is a little confusing. It's not clear that the phrase refers to the feature as we've named it in the application.
- Although the delay/failure may have been due to the network connection, other factors could be involved. With this being a client/server application, it seems odd to have the user check their own computer's network connection, given the delay is between the application and the database.
- The phrase "try again" is not specific enough for a user. We need to be clear about what it is they're to "try again".
Verification steps
- Set network throttle to Slow 3G
- Go to https://gitlab.com/groups/gitlab-org/-/security/dashboard
- Once page is being loaded, switch network throttle to Offline
- Verify you see the message "Failed to retrieve the vulnerability data. Please refresh the page." in an error alert.
Edited by Lorenz van Herwaarden