Skip to content

Toggle comments for this file button doesn't work at all

Summary

(Reminiscent of - but much more severe than - #30356 (closed)).

The Toggle comments for this file button in the MR Changes view does not work.

Firefox 71.0
Ubuntu 19.10
GitLab Next (Identical behavior on Current)

Steps to reproduce

  1. Any MR with diff file line changes.
  2. Comment on any line
  3. Attempt to use the "Toggle comments for this file" button.
  4. Nothing happens

Example Project

https://gitlab.com/thomasrandolph/better-team-page/merge_requests/1/diffs

What is the current bug behavior?

The comments don't expand when they're closed, and they don't close when they're expanded.

What is the expected correct behavior?

The comments should close if any are expanded, and then they should open (if they're all closed) and close (if they're all open).

Relevant logs and/or screenshots

For the record, whenever I'm hovering over the button, I'm clicking it. It's not visible, but I click it a large number of times in this video, probably 15-25 times.

There are no errors in the browser console.

simplescreenrecorder-2019-12-11_00.08.22

Output of checks

This bug happens on GitLab.com and GitLab.com Next

Possible fixes

The diffs data and state are intense and I have no idea, sorry :)

Edited by Thomas Randolph