Enabling Omniauth causes GitLab to no longer report user_session_logins_total metric

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Work on this issue
• Close this issue

Summary

When enabling Omniauth, gitlab-exporter no longer exports the user_session_logins_total metrics.

Steps to reproduce

1. Enable Omniauth in gitlab.rb or values.yaml.
2. Logni via the provider
3. Check the /-/metrics endpoint for user_session_logins_total

Example Project

What is the current bug behavior?

When enabling Omniauth, the user_session_logins_total metric is no longer exported.

What is the expected correct behavior?

GitLab should export the user_session_logins_total metrics, regardless if Omniauth is enabled or not.

Relevant logs and/or screenshots

# Before enabling Omniauth
$ curl -s -A 'gitlab-testing' https://[REDACTED]/-/metrics | grep user_session
[...]
user_session_logins_total 3

# After enabling Omniauth
$ curl -s -A 'gitlab-testing' https://[REDACTED]/-/metrics | grep user_session

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info

System information
System:
Proxy:		no
Current User:	git
Using RVM:	no
Ruby Version:	2.7.7p221
Gem Version:	3.2.33
Bundler Version:2.3.15
Rake Version:	13.0.6
Redis Version:	6.0.16
Sidekiq Version:6.5.7
Go Version:	unknown

GitLab information
Version:	15.8.1-ee
Revision:	c49deff6e37
Directory:	/srv/gitlab
DB Adapter:	PostgreSQL
DB Version:	12.7
URL:		https://[REDACTED]
HTTP Clone URL:	https://[REDACTED]/some-group/some-project.git
SSH Clone URL:	git@[REDACTED]:some-group/some-project.git
Elasticsearch:	no
Geo:		no
Using LDAP:	no
Using Omniauth:	yes
Omniauth Providers: gitlab

GitLab Shell
Version:	14.15.0
Repository storages:
- default: 	tcp://gitlab-dcoy-gitaly-0.gitlab-dcoy-gitaly.default.svc:8075
GitLab Shell path:		/home/git/gitlab-shell

Results of GitLab application Check

Expand for output related to the GitLab application check

(For installations with omnibus-gitlab package run and paste the output of:
sudo gitlab-rake gitlab:check SANITIZE=true)
(For installations from source run and paste the output of:
sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true)
(we will only investigate if the tests are passing)

Possible fixes