MR widget shows checking state when a MR dependency is added on an already approved MR
Summary
When a MR dependency is added to a MR that is already approved, it shows the "Checking..." state instead of the "Merge blocked" state.
This doesn't happen when MR doesn't require any approval.
Steps to reproduce
- Open a MR with required approval.
- Approved the MR.
- Add a dependency to the MR to block its merge.
- See that the MR widget is showing the "Checking if merge request can be merged…" state instead of the "Merge blocked: you can only merge after the above items are resolved." state.
Sample MR on production: patrickbajao/verification!75
What is the current bug behavior?
MR widget is showing the "Checking if merge request can be merged…" state instead of the "Merge blocked: you can only merge after the above items are resolved." state.
What is the expected correct behavior?
"Merge blocked: you can only merge after the above items are resolved." state should be shown instead.
Relevant logs and/or screenshots
Edited by Patrick Bajao