Forbid setting NO_ACCESS to unprotect-access-level for protected branches
Why are we doing this work
As described #345277 (closed)
Users have the ability via the protected branch api to set unprotect-access-level to NO_ACCESS. This creates a problem where no users are able to unprotect a protected branch.
During discussion in #345277 (comment 1254166347) it was decided to remove the NO_ACCESS option for unprotect-access-level, while not modifying/breaking unprotect-access-level values which are currently set to NO_ACCESS.
Relevant links
Non-functional requirements
- Documentation: specify that NO_ACCESS is no longer available for unprotect-access-level
- Testing: confirm that this change does not effect protected branches which currently have NO_ACCES set.
Designs
- Show closed items
Relates to
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Gavin Hinfey mentioned in issue #345277 (closed)
mentioned in issue #345277 (closed)
- Maintainer
@ghinfey, Please add a group or category label to identify issue ownership. You can refer to the Features by Group handbook page for guidance. If you are unsure about the correct group, please do not leave the issue without a group label. Please refer to GitLab's shared responsibility functionality guidelines for more information on how to triage this kind of issue. - Gavin Hinfey mentioned in merge request !112035 (merged)
mentioned in merge request !112035 (merged)
- Contributor
This issue was automatically tagged with the label groupsource code by TanukiStan, a machine learning classification model, with a probability of 0.98.
If this label is incorrect, please tag this issue with the correct group label as well as automation:ml wrong to help TanukiStan learn from its mistakes.
If you are unsure about the correct group, please do not leave the issue without a group label. Please refer to GitLab's shared responsibility functionality guidelines for more information on how to triage this kind of issues.
Authors who do not have permission to update labels can leave the issue to be triaged by group leaders initially assigned by TanukiStan
This message was generated automatically. You're welcome to improve it.
- A deleted user added automation:ml groupsource code labels
added automation:ml groupsource code labels
- 🤖 GitLab Bot 🤖 added devopscreate sectiondev labels
added devopscreate sectiondev labels
- Gavin Hinfey added typebug label
added typebug label
- Gavin Hinfey added backend label
added backend label
- Gavin Hinfey added Category:Source Code Management label
added Category:Source Code Management label
- Sean Carroll marked this issue as related to #345277 (closed)
marked this issue as related to #345277 (closed)
- Developer
- Sean Carroll added priority2 severity2 labels
- Developer
Adding to %16.0 planning.
- Sean Carroll changed milestone to %16.0
changed milestone to %16.0
- Sean Carroll added bugfunctional label
added bugfunctional label
- Gavin Hinfey added workflowin review label
added workflowin review label
- Author Maintainer
Hi @sean_carroll, I have an MR for this in review, I've added the label.
Collapse replies - Developer
- Sean Carroll changed milestone to %15.10
changed milestone to %15.10
- Amy Qualls mentioned in merge request !112869 (merged)
mentioned in merge request !112869 (merged)
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#11596 (closed)
mentioned in issue gitlab-org/quality/triage-reports#11596 (closed)
- Maintainer
@sean_carroll, @tlinz and @a_mcdonald,This groupsource code bug has at most 50% of the SLO duration remaining and is an SLONear Miss breach. Please consider taking action before this becomes an SLOMissed in 29 days (2023-04-18).
- 🤖 GitLab Bot 🤖 changed due date to April 18, 2023
changed due date to April 18, 2023
- 🤖 GitLab Bot 🤖 added SLONear Miss label
added SLONear Miss label
- 🤖 GitLab Bot 🤖 changed milestone to %15.11
changed milestone to %15.11
- 🤖 GitLab Bot 🤖 added missed:15.10 label
added missed:15.10 label
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#12021 (closed)
mentioned in issue gitlab-org/quality/triage-reports#12021 (closed)
- Joe Woodward mentioned in merge request !117689 (merged)
mentioned in merge request !117689 (merged)
- 🤖 GitLab Bot 🤖 added SLOMissed label and removed SLONear Miss label
added SLOMissed label and removed SLONear Miss label
- 🤖 GitLab Bot 🤖 changed milestone to %16.0
changed milestone to %16.0
- 🤖 GitLab Bot 🤖 added missed:15.11 label
added missed:15.11 label
- Maintainer
I think we'll have a small API. documentation change as part of this work, so I'm adding the labels.
- Amy Qualls added Technical Writing documentation labels
added Technical Writing documentation labels
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#12373 (closed)
mentioned in issue gitlab-org/quality/triage-reports#12373 (closed)
- Sean Carroll added workflowcomplete label and removed workflowin review label
added workflowcomplete label and removed workflowin review label
- 🤖 GitLab Bot 🤖 changed milestone to %16.1
changed milestone to %16.1
- 🤖 GitLab Bot 🤖 added missed:16.0 label
added missed:16.0 label
- Amy Qualls added twtriaged label
added twtriaged label
- 🤖 GitLab Bot 🤖 changed milestone to %16.2
changed milestone to %16.2
- 🤖 GitLab Bot 🤖 added missed:16.1 label
added missed:16.1 label
- Developer
- Sean Carroll closed
closed
- 🤖 GitLab Bot 🤖 mentioned in issue gitlab-org/quality/triage-reports#13269 (closed)
mentioned in issue gitlab-org/quality/triage-reports#13269 (closed)