Reuse MergeChecksApp Vue component in app/views/projects/_merge_request_pipelines_and_threads_options.html.haml

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Close this issue

The following discussion from !102863 (merged) should be addressed:

• @eduardosanz started a discussion: (+2 comments)

  question: in the future, do you think we could replace app/views/projects/_merge_request_pipelines_and_threads_options.html.haml for our new Vue component? I think this is possible by adding a Rails helper, app/helpers/merge_checks_helper.rb, that doesn't contain any setting cascading ability.

  I think the above has the following benefits:

  • it allows all the merge checks (app and ee group ee project) to use consistently the same Vue component.
  • the app version will gain the conditional behaviour just introduced. Screen_Recording_2023-02-08_at_12.58.33
  • it allows to remove a HAML: app/views/projects/_merge_request_pipelines_and_threads_options.html.haml