A suggestions can change lines not included in the suggestion
Summary
In an MR just now, when two suggestions were applied, the second one made changes not included in the suggestion itself. See:
What is the current bug behavior?
Have not been able to test this yet, but the steps that happened:
- MR was reviewed, and two suggestions were made in "review mode", and thus submitted at the same time. Both suggestions were for 2 lines, in different places.
- The suggestion listed second (in case that's important) was checked by the author first, and then applied.
- Then, the suggestion listed first (in case that's important) was checked, and then applied.
- When reviewing the changes, I noticed that the second time a suggestion was applied, it changed four lines, not two, and in effect reverted the change applied in the first suggestion.
Links
Suggestion 1: !21237 (comment 257300775)
Suggestion 2: !21237 (comment 257300787)
