Follow-up from "Add directionality field to JobToken::RemoveProject GraphQL mutation"
The following discussions from !110669 (merged) should be addressed:
-
@group_9970_bot2 started a discussion: let_it_be(:target_project) { create(:project) }
Project creations are very slow. Use
let_it_be
,build
orbuild_stubbed
if possible. See testing best practices for background information and alternative options. -
@Kasia_Misirli started a discussion: suggestion: Here could also just test that when the RemoveProjectService execute method is called, it then calls the ::Ci::JobToken::ProjectScopeLink with the correct(expected) value. Given that this class sets the default value, we should have a test for that as well. Just testing what actually belongs to the class.
we can test the default in a follow-up
-
@Kasia_Misirli started a discussion suggestion: I understand that we are trying to have the tests in the request specs (saw that in another MR at Gitlab) and we want to check the response here, and to some extent I agree that we should do it. Eg test response code and maybe the response body (debatable but still valid IMO).