Filter merge requests approved by user
Problem to solve
It's not possible to search for merge requests that someone/myself have approved.
We also have a filter that suggests you can do this type of filter called: Approvers, but the name is misleading, as it will only list merge requests which the user is listed as an potential approver (either by being manually added to it, by its relationship in a group which is part of the approvers, or by it being listed in CODEOWNERS of an affected file).
Intended users
Further details
This is very important for trainee maintainers, as trying to figure out which merge requests you gave an approval after you did, it's almost impossible or too time consuming.
This is also important for when training a more junior developer, to be able to review their progress by looking at places where they gave an approval, or simply for anyone trying to find places they have made a good contribution for career development evaluation.
Proposal
Add another filter when searching for Merge Requests: Approved by (following the same semantics as the existing Approvers, allowing to select an user, none or any)
Permissions and Security
Same search restrictions as any other filters.
Documentation
Add new filter in :
- https://docs.gitlab.com/ee/user/project/merge_requests/merge_request_approvals.html (with frontend changes)
- https://docs.gitlab.com/ee/api/merge_requests.html (with backend changes)
Testing
What does success look like, and how can we measure that?
Being able to search for merge requests a specific user has approved using by pressing the approve button.
What is the type of buyer?
Same as Approvals (starter/bronze)