undefined method `remove_source_branch_after_merge'

Summary

After upgrading to gitlab v12.5.3-ee via Helm, certain operations are returning a 500 in the UI

Steps to reproduce

So far, we can reliably reproduce the problem in two different types of interactions with the UI

  1. From any repo, navigating to Settings -> General
  2. Trying to create a new project/repo

Screen_Shot_2019-12-08_at_12.52.05_PM

What is the current bug behavior?

UI returns "Whoops" .. 500 screen

What is the expected correct behavior?

Display the requested view

Relevant logs and/or screenshots

ActionView::Template::Error (undefined method `remove_source_branch_after_merge' for #<Project id:182 tools/wan-emulator>

Did you mean?  remove_fork_namespace_project_url):

    13:     = form.label :printing_merge_request_link_enabled, class: 'form-check-label' do

    14:       = s_('ProjectSettings|Show link to create/view merge request when pushing from the command line')

    15:   .form-check.mb-2

    16:     = form.check_box :remove_source_branch_after_merge, class: 'form-check-input'

    17:     = form.label :remove_source_branch_after_merge, class: 'form-check-label' do

    18:       = s_("ProjectSettings|Enable 'Delete source branch' option by default")

    19:       .descr.text-secondary

app/views/projects/_merge_request_merge_options_settings.html.haml:16:in `_app_views_projects__merge_request_merge_options_settings_html_haml__2811364628296726837_47191195332440'

ee/app/helpers/ee/application_helper.rb:43:in `render_ce'

ee/app/views/projects/_merge_request_settings.html.haml:5:in `_ee_app_views_projects__merge_request_settings_html_haml___983041680508898079_47191189962140'

app/views/projects/edit.html.haml:37:in `block in _app_views_projects_edit_html_haml__3206186215256721122_47191178171300'

app/views/projects/edit.html.haml:35:in `_app_views_projects_edit_html_haml__3206186215256721122_47191178171300'

app/controllers/application_controller.rb:108:in `render'

app/controllers/projects_controller.rb:52:in `edit'

ee/lib/gitlab/ip_address_state.rb:10:in `with'

ee/app/controllers/ee/application_controller.rb:43:in `set_current_ip_address'

lib/gitlab/session.rb:11:in `with_session'

app/controllers/application_controller.rb:450:in `set_session_storage'

lib/gitlab/i18n.rb:55:in `with_locale'

lib/gitlab/i18n.rb:61:in `with_user_locale'

app/controllers/application_controller.rb:444:in `set_locale'

lib/gitlab/middleware/rails_queue_duration.rb:27:in `call'

lib/gitlab/metrics/rack_middleware.rb:17:in `block in call'

lib/gitlab/metrics/transaction.rb:62:in `run'

lib/gitlab/metrics/rack_middleware.rb:17:in `call'

lib/gitlab/request_profiler/middleware.rb:17:in `call'

ee/lib/gitlab/jira/middleware.rb:19:in `call'

lib/gitlab/middleware/go.rb:20:in `call'

lib/gitlab/etag_caching/middleware.rb:13:in `call'

lib/gitlab/middleware/correlation_id.rb:16:in `block in call'

lib/gitlab/middleware/correlation_id.rb:15:in `call'

lib/gitlab/middleware/multipart.rb:117:in `call'

lib/gitlab/middleware/read_only/controller.rb:48:in `call'

lib/gitlab/middleware/read_only.rb:18:in `call'

lib/gitlab/middleware/basic_health_check.rb:25:in `call'

lib/gitlab/request_context.rb:32:in `call'

config/initializers/fix_local_cache_middleware.rb:9:in `call'

lib/gitlab/metrics/requests_rack_middleware.rb:49:in `call'

lib/gitlab/middleware/release_env.rb:12:in `call'

Started GET "/prototype/manetu-login-ui.git/info/refs?service=git-upload-pack" for 172.19.0.114 at 2019-12-08 17:46:07 +0000

Processing by Projects::GitHttpController#info_refs as */*

  Parameters: {"service"=>"git-upload-pack", "namespace_id"=>"prototype", "project_id"=>"manetu-login-ui.git"}

Completed 200 OK in 30ms (Views: 0.4ms | ActiveRecord: 6.3ms | Elasticsearch: 0.0ms)

Output of checks

Results of GitLab environment info

$ gitlab-rake gitlab:env:info
WARNING: This version of GitLab depends on gitlab-shell 10.2.0, but you're running Unknown. Please update gitlab-shell.

System information
System:
Proxy:          no
Current User:   git
Using RVM:      no
Ruby Version:   2.6.3p62
Gem Version:    2.7.9
Bundler Version:1.17.3
Rake Version:   12.3.3
Redis Version:  unknown
Git Version:    unknown
Sidekiq Version:5.2.7
Go Version:     unknown

GitLab information
Version:        12.5.3-ee
Revision:       63955893276
Directory:      /srv/gitlab
DB Adapter:     PostgreSQL
DB Version:     9.6.8
URL:            https://gitlab.svc.manetu.com
HTTP Clone URL: https://gitlab.svc.manetu.com/some-group/some-project.git
SSH Clone URL:  git@gitlab.svc.manetu.com:some-group/some-project.git
Elasticsearch:  no
Geo:            no
Using LDAP:     yes
Using Omniauth: no

GitLab Shell
Version:        unknown
Repository storage paths:
- default:      /var/opt/gitlab/repo
GitLab Shell path:              /home/git/gitlab-shell
Git:            /usr/bin/git

Results of GitLab application Check

$ gitlab-rake gitlab:check SANITIZE=true
WARNING: This version of GitLab depends on gitlab-shell 10.2.0, but you're running Unknown. Please update gitlab-shell.
Checking GitLab subtasks ...

Checking GitLab Shell ...

GitLab Shell: ... GitLab Shell version >= 10.2.0 ? ... FAIL. Please update gitlab-shell to 10.2.0 from Unknown
Running /home/git/gitlab-shell/bin/check
gitlab-shell self-check failed
  Try fixing it:
  Make sure GitLab is running;
  Check the gitlab-shell configuration file:
  sudo -u git -H editor /home/git/gitlab-shell/config.yml
  Please fix the error above and rerun the checks.

Checking GitLab Shell ... Finished

Checking Gitaly ...

Gitaly: ... default ... OK

Checking Gitaly ... Finished

Checking Sidekiq ...

Sidekiq: ... Running? ... no
  Try fixing it:
  sudo -u git -H RAILS_ENV=production bin/background_jobs start
  For more information see:
  doc/install/installation.md in section "Install Init Script"
  see log/sidekiq.log for possible errors
  Please fix the error above and rerun the checks.

Checking Sidekiq ... Finished

Checking Incoming Email ...

Incoming Email: ... Reply by email is disabled in config/gitlab.yml

Checking Incoming Email ... Finished

Checking LDAP ...

LDAP: ... Server: ldapmain
LDAP authentication... Success
LDAP users with access to your GitLab server (only showing the first 100 results)
        User output sanitized. Found 23 users of 100 limit.

Checking LDAP ... Finished

Checking GitLab App ...

Git configured correctly? ... no
Trying to fix error automatically. ...Failed
  Try fixing it:
  sudo -u git -H "/usr/bin/git" config --global core.autocrlf "input"
  For more information see:
  doc/install/installation.md in section "GitLab"
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... skipped (no tmp uploads folder yet)
Init script exists? ... no
  Try fixing it:
  Install the init script
  For more information see:
  doc/install/installation.md in section "Install Init Script"
  Please fix the error above and rerun the checks.
Init script up-to-date? ... can't check because of previous errors
Projects have namespace: ... 
6/3 ... yes
5/5 ... yes
6/6 ... yes
2/7 ... yes
2/9 ... yes
10/10 ... yes
3/11 ... yes
3/13 ... yes
5/15 ... yes
5/16 ... yes
6/17 ... yes
2/22 ... yes
3/23 ... yes
2/24 ... yes
11/26 ... yes
2/29 ... yes
6/30 ... yes
3/31 ... yes
3/33 ... yes
2/34 ... yes
3/35 ... yes
7/37 ... yes
3/44 ... yes
3/45 ... yes
3/46 ... yes
2/49 ... yes
3/52 ... yes
3/57 ... yes
3/59 ... yes
3/61 ... yes
5/66 ... yes
3/69 ... yes
2/70 ... yes
3/71 ... yes
3/72 ... yes
3/74 ... yes
3/77 ... yes
24/83 ... yes
22/84 ... yes
27/86 ... yes
22/87 ... yes
24/90 ... yes
28/92 ... yes
26/93 ... yes
36/94 ... yes
36/95 ... yes
36/96 ... yes
24/97 ... yes
26/98 ... yes
29/99 ... yes
46/100 ... yes
38/101 ... yes
38/102 ... yes
38/103 ... yes
38/104 ... yes
38/105 ... yes
38/106 ... yes
38/107 ... yes
41/108 ... yes
41/109 ... yes
41/110 ... yes
42/111 ... yes
38/112 ... yes
48/113 ... yes
41/114 ... yes
41/115 ... yes
38/116 ... yes
38/117 ... yes
52/118 ... yes
52/119 ... yes
52/120 ... yes
52/121 ... yes
61/122 ... yes
53/123 ... yes
24/124 ... yes
25/126 ... yes
25/127 ... yes
25/128 ... yes
25/129 ... yes
23/130 ... yes
40/131 ... yes
37/132 ... yes
26/133 ... yes
24/135 ... yes
23/136 ... yes
23/137 ... yes
25/138 ... yes
24/140 ... yes
40/141 ... yes
40/142 ... yes
40/143 ... yes
40/144 ... yes
40/147 ... yes
40/148 ... yes
24/149 ... yes
25/150 ... yes
26/151 ... yes
47/152 ... yes
45/153 ... yes
24/154 ... yes
23/156 ... yes
28/157 ... yes
55/158 ... yes
55/159 ... yes
33/160 ... yes
33/161 ... yes
28/162 ... yes
56/163 ... yes
25/167 ... yes
57/168 ... yes
57/169 ... yes
57/170 ... yes
25/171 ... yes
62/174 ... yes
62/175 ... yes
44/176 ... yes
24/177 ... yes
32/178 ... yes
35/179 ... yes
25/180 ... yes
57/181 ... yes
11/182 ... yes
26/184 ... yes
28/185 ... yes
53/186 ... yes
21/187 ... yes
45/188 ... yes
24/189 ... yes
23/190 ... yes
63/191 ... yes
Redis version >= 2.8.0? ... no
  Try fixing it:
  Update your redis server to a version >= 2.8.0
  For more information see:
  gitlab-public-wiki/wiki/Trouble-Shooting-Guide in section sidekiq
  Please fix the error above and rerun the checks.
Ruby version >= 2.5.3 ? ... yes (2.6.3)
Git version >= 2.22.0 ? ... no
Your git bin path is "/usr/bin/git"
  Try fixing it:
  Update your git to a version >= 2.22.0 from Unknown
  Please fix the error above and rerun the checks.
Git user has default SSH configuration? ... yes
Active users: ... 19
Is authorized keys file accessible? ... skipped (authorized keys not enabled)
Elasticsearch version 5.6 - 6.x? ... skipped (elasticsearch is disabled)

Checking GitLab App ... Finished


Checking GitLab subtasks ... Finished