Feedback issue: Micro Code Review Frontend PoC
What are we providing feedback on?
- Brief Overview video: https://youtu.be/1FlONoxx61s
- PoC Caveats: $2488482
- Live application oAuth’ed: https://dainty-cannoli-bb66bf.netlify.app/
- Code: https://gitlab.com/thomasrandolph/code-review
Context
In our pursuit for crazy ideas (create-stage#13075 (closed)) and learning from explorations, @thomasrandolph has been exploring a lean way of rendering MR diffs under the Epic: Micro Code Review &9472
Our goal is to kick the tires of this approach and check if there are portions we can build back into our product to benefit the performance of Merge Requests (diffs in general) as a whole. Looking for major impact changes, here.
Further context
As we look for better ways to render diffs in MRs, we should also keep in mind there are several other places in GitLab that are still rendering diffs using an old codebase. So whatever we do, it should try to accommodate diffs outside of MRs, too. If possible.
Namely, these are the places we have diffs currently:
- Repository commit diffs: HAML SSR
- Compare branches: Vue branch pickers, diffs in HAML SSR
- New/edit MR form : HAML SSR
- MR Changes tab: Vuex app
(please correct if any is wrong)