Show setting for CODEOWNER Approval in Branch Rule detail view
Problem
The unreleased Branch Rule detail view does not yet show whether CODEOWNER approval is required.
Overview | Detail view |
---|---|
![]() |
![]() |
Proposal
This feature aims at showing whether CODEOWNER approval is required.
Design
- Ordering of the content needs to change:
- Display merge setting then push settings.
- Display enabled settings with a
status-success
icon - Display disabled settings with a
status-failed
icon
Example of different states
Mockup
All disabled | All enabled |
---|---|
![]() |
![]() |
There should be a tooltip to explain where the link will take the user to. This is similar to same pattern as #389419 (closed)
If linking to CODEOWNERS is not possible, default to text only presentation
| All disabled | All enabled | | ------ | ------ | |![image](/-/project/278964/uploads/2ce7a0b7477c4ca99af7ff92742bc3ac/image.png)
![image](/-/project/278964/uploads/62a349e3d638e527a1e0e1fdf53cb731/image.png)
Availability and Testing
Exploratory testing in MR, lower level specs + possible changes to Code Owner E2Es - please assign a SET for an MR review.
Edited by Anastasia McDonald