Gitlab::Database::GitlabSchema.table_schema to return nil if the table schema not found instead of :undefined_TABLE_NAME
As part of this MR comment it was pointed out that we introduced some complexity by making the method table_schema
returns two possible results if the table's gitlab_schema
is not defined.
But as part of the MR itself, we are going to require a gitlab_schema
to be set for any created table. That's why I am opening this issue here to discuss the possibility of making this method return nil
instead, and delegating the responsibility to convert it into :undefined_<TABLE_NAME>
to the caller instead, if needed.
I have opened this POC MR before to see the impact of this change.
- This is a follow up for: #381499 (closed)
- Related MR discussion: !99287 (comment 1150688548)
Edited by Omar Qunsul