Remove Gitlab::UsageDataCounters::TrackUniqueEvents
Problem
Gitlab::UsageDataCounters::TrackUniqueEvents
looks like an early attempt at standardizing event tracking, but after almost three years, it's way off the current philosophy we have about Snowplow events. The different actions are mapped to the same events, so the action logic within the class is superfluous at best; it's become technical debt and an obstacle to removal or refactoring of counter classes, since it's embedded in the Gitlab::UsageDataCounters
namespace.
Proposal
-
Replace calls to Gitlab::UsageDataCounters::TrackUniqueEvents
with calls directly firing the events related to actions. -
RemoveRemoval of the metric was moved to #391946 (closed)usage_activity_by_stage_monthly.create.merge_requests_users
metric that is a duplicate ofredis_hll_counters.source_code.merge_request_action_{monthly, weekly}
and its logic inGitlab::UsageData
as it's not using instrumentation classes. -
Announce the removal to the owners of the metrics- groupcode review. -
Remove Gitlab::UsageDataCounters::TrackUniqueEvents
.
Edited by Sebastian Rehm