Migrate analytics dashboard project selector to relevant GlDropdown
Problem to solve
The following discussion from !108235 (merged) should be addressed:
- We're not using the correct component for select. Is there a reason for that? Can we correct that through this MR?
- Same for the dropdown, it's not the correct component. I recently reviewed an MR for migrating from old dropdown to the new component. Could we use that component here too so that we don't introduce tech debt?
Additional information
General UX feedback from !108235 (comment 1241822940)
But I see that it's there to remove a project once it was selected and saved. I recently learned that we use this pattern for saving settings files in projects elsewhere, is this the pattern that we always use? I think a better option would be to include the option "None" in the dropdown.
It's also unclear that after I click on the clear icon and the project is removed, that I need to click Save changes to confirm that. If there was the "None" option in the dropdown, I think that would be clearer.
This additional UX feedback was moved to #392675
Selectors to migrate
- https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/app/views/groups/_analytics_dashboards.html.haml
- https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/app/views/projects/settings/_analytics_dashboards.html.haml
- https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/app/views/groups/_insights.html.haml
Edited by Ezekiel Kigbo