Follow-up: Update product analytics documentation with all the feature flags needed
The following discussion from !107966 (merged) should be addressed:
-
@himkp started a discussion: (+2 comments) Hi @timzallmann This MR looks good. I tested it out locally, and it all works fine. Thanks @ekigbo for setting up things in your branch, it made testing easier for me.
😄 Just wanted to add that we needed to enable one more feature flag to get "Product analytics" to show up in admin settings, which isn't documented anywhere:
product_analytics_admin_settings
I have a few comments mostly related to UX though.
- Changing the type of button from secondary to primary for the "Code" button doesn't seem natural. Should probably rethink how we toggle it.
- The code seems to be view only, which is okay for now.
- There's no save button to persist the data, which I guess will come in future iterations.
The core functionality of resizing, moving and showing code as mentioned in the MR description works well, so I will approve.