Flaky test spec/policies/group_policy_spec.rb:1089
Summary
Job #3580245124 failed for 74d5e6f8:
Failures:
1) GroupPolicy support bot when group hierarchy has a project with service desk enabled is expected to be allowed :read_label
Failure/Error: permissions.each { |p| is_expected.to be_allowed(p) }
expected `#<GroupPolicy (@support-bot : Group/1873)>.allowed?(:read_label)` to be truthy, got false
# ./spec/support/helpers/policy_helpers.rb:5:in `block in expect_allowed'
# ./spec/support/helpers/policy_helpers.rb:5:in `each'
# ./spec/support/helpers/policy_helpers.rb:5:in `expect_allowed'
# ./spec/policies/group_policy_spec.rb:1089:in `block (4 levels) in <top (required)>'
# ./spec/spec_helper.rb:415:in `block (3 levels) in <top (required)>'
# ./spec/support/sidekiq_middleware.rb:18:in `with_sidekiq_server_middleware'
# ./spec/spec_helper.rb:407:in `block (2 levels) in <top (required)>'
# ./spec/spec_helper.rb:403:in `block (3 levels) in <top (required)>'
# ./lib/gitlab/application_context.rb:59:in `with_raw_context'
# ./spec/spec_helper.rb:403:in `block (2 levels) in <top (required)>'
# ./spec/spec_helper.rb:239:in `block (2 levels) in <top (required)>'
# ./spec/support/system_exit_detected.rb:7:in `block (2 levels) in <top (required)>'
# ./spec/support/flaky_tests.rb:27:in `block (2 levels) in <top (required)>'
# ./spec/support/database/prevent_cross_joins.rb:106:in `block (3 levels) in <top (required)>'
# ./spec/support/database/prevent_cross_joins.rb:60:in `with_cross_joins_prevented'
# ./spec/support/database/prevent_cross_joins.rb:106:in `block (2 levels) in <top (required)>'
Finished in 42 minutes 24 seconds (files took 1 minute 25.6 seconds to load)
3799 examples, 1 failure, 27 pending
Failed examples:
rspec ./spec/policies/group_policy_spec.rb:1089 # GroupPolicy support bot when group hierarchy has a project with service desk enabled is expected to be allowed :read_label
Randomized with seed 39445
[TEST PROF INFO] Time spent in factories: 17:19.926 (40.23% of total time)
Stopped processing SimpleCov as a previous error not related to SimpleCov has been detected
RSpec exited with 1.
Steps to reproduce
$ RSPEC_WARN_MISSING_FEATURE_CATEGORY=0 bin/rspec ./spec/policies/group_po
licy_spec.rb[1:27:1,1:27:2:1] --seed 16138
Run options: include {:focus=>true, :ids=>{"./spec/policies/group_policy_spec.rb"=>["1:27:1", "1:27:2:1"]}}
Randomized with seed 16138
Test environment set up in 5.102112541 seconds
GroupPolicy
support bot
is expected not to be allowed :read_label
when group hierarchy has a project with service desk enabled
is expected to be allowed :read_label (FAILED - 1)
Failures:
1) GroupPolicy support bot when group hierarchy has a project with service desk enabled is expected to be allowed :read_label
Failure/Error: permissions.each { |p| is_expected.to be_allowed(p) }
expected `#<GroupPolicy (@support-bot : Group/25630)>.allowed?(:read_label)` to be truthy, got false
# ./spec/support/helpers/policy_helpers.rb:5:in `block in expect_allowed'
# ./spec/support/helpers/policy_helpers.rb:5:in `each'
# ./spec/support/helpers/policy_helpers.rb:5:in `expect_allowed'
# ./spec/policies/group_policy_spec.rb:1089:in `block (4 levels) in <top (required)>'
# ./spec/spec_helper.rb:415:in `block (3 levels) in <top (required)>'
# ./spec/support/sidekiq_middleware.rb:18:in `with_sidekiq_server_middleware'
# ./spec/spec_helper.rb:407:in `block (2 levels) in <top (required)>'
# ./spec/spec_helper.rb:403:in `block (3 levels) in <top (required)>'
# ./lib/gitlab/application_context.rb:59:in `with_raw_context'
# ./spec/spec_helper.rb:403:in `block (2 levels) in <top (required)>'
# ./spec/spec_helper.rb:239:in `block (2 levels) in <top (required)>'
# ./spec/support/system_exit_detected.rb:7:in `block (2 levels) in <main>'
# ./spec/support/database/prevent_cross_joins.rb:106:in `block (3 levels) in <main>'
# ./spec/support/database/prevent_cross_joins.rb:60:in `with_cross_joins_prevented'
# ./spec/support/database/prevent_cross_joins.rb:106:in `block (2 levels) in <main>'
Finished in 7.95 seconds (files took 8.52 seconds to load)
2 examples, 1 failure
Failed examples:
rspec ./spec/policies/group_policy_spec.rb:1089 # GroupPolicy support bot when group hierarchy has a project with service desk enabled is expected to be allowed :read_label
Randomized with seed 16138
[TEST PROF INFO] Time spent in factories: 00:01.211 (13.27% of total time)
Proposed Resolution
Prefer before
over before_all
for updating group attributes. This is
needed because in group uses refind: true
(in shared context) which
doesn't play well with before_all
.
Clear memoization for Group#has_project_with_service_desk_enabled?
by
using let_it_be_with_refind
.
See !109041 (merged)
Job #3580245124 failed for 74d5e6f8:
Edited by Peter Leitzen