Add merge request notes

  • Displays information about MRs that were created for the given finding. This includes the creation date, details about the author, and a link to the MR.
  • Feedback is in vulnerability.merge_request_feedback

Props

feedback

{
      author: {
        id: '1',
        name: 'Dave',
        username: 'davepies',
        path: 'davpies.me',
        is_gitlab_employee: true,
      },
      created_at: '2022-11-17T09:33:07.971Z',
      merge_request_path: '/merge/foo',
      merge_request_iid: 1,
    }
    

project

{
        url: '/foo/bar',
        value: 'Foo / Bar',
    }
    

Endpoints

  • Pipeline: GET /api/v4/projects/34/vulnerability_findings?pipeline_id=1
  • MR Widget: GET /security/security-reports/-/merge_requests/5/sast_reports (for reach report type)

Screenshot

image

Implementation Plan

  • GraphQL field: PipelineSecurityReportFinding.mergeRequest
  • Create GraphQL version of ee/app/assets/javascripts/vue_shared/security_reports/components/merge_request_note.vue (current component expects snake-cased data)
  • Add specs
Edited by David Pisek