Investigate removal of requires_new in Vulnerabilities::CreateService
Why are we doing this work
We need to investigate removal of requires_new in Vulnerabilities::CreateService. This can cause subtransactions as described in https://gitlab.com/gitlab-com/runbooks/-/blob/master/docs/patroni/postgresql-subtransactions.md. This has come to light especially with the inclusion of this code for Vulnerabilities::FindOrCreateFromSecurityFindingService.
Relevant links
Issue created due to subtransaction
Implementation plan
- Remove
requires_new: truefrom transaction start inVulnerabilities::CreateService - Ensure no regressions
- Reschedule
MigrateVulnerabilitiesFeedbackToVulnerabilitiesStateTransition
Edited by Michał Zając