Bug fix: SearchFilesByName errors when starting with a dash for advanced search
Summary
According to logs in kibana, we have advanced searches that are failing with the error such as:
GRPC::Internal
13:cmd start failed: positional arg "- failed -" cannot start with dash '-': invalid argument. debug_error_string: "grpc_message":"cmd start failed: positional arg "- failed -" cannot start with dash '-': invalid argument","grpc_status":13}
This is similar to #382489 (closed) but for advanced search, not basic search.
Steps to reproduce
What is the current bug behavior?
Searching for a filename that starts with a dash causes a 500 error.
What is the expected correct behavior?
We should be able to deal with files starting with dashes.
Relevant logs and/or screenshots
Possible fixes
Escape query strings starting with a dash when making a call to lib/gitlab/gitaly_client/repository_service.rb: search_file_by_name.