Refactor vrange/python resolver to use cli.Register
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
Summary
As part of gitlab-org/security-products/analyzers/gemnasium!447 (merged), a new vrange resolver was registered
for vrange/python that directly used the resolver.Register function. This was shipped to quickly
fix the issue, but some follow up actions were identified as part of the code review.
Improvements
- Use consistent error formatting in
scanner/scanner.go. See gitlab-org/security-products/analyzers/gemnasium!447 (comment 1205692480) - Update the changelog to mention using pipenv directly in
v3.10.8. See gitlab-org/security-products/analyzers/gemnasium!447 (comment 1203145488) - Update error messages to use consistent styling in
vrange/cli/cli.go. See gitlab-org/security-products/analyzers/gemnasium!447 (comment 1203145482) - Correct typos. See gitlab-org/security-products/analyzers/gemnasium!447 (comment 1203145479) and gitlab-org/security-products/analyzers/gemnasium!447 (comment 1204478090)
- Update the
Resolverstruct so that it sets the working directory of the resolver commands for all vrange resolvers. See theResolver.Resolvefunction.
Risks
N/A
Involved components
vrange/python/python.govrange/cli/cli.go
Optional: Intended side effects
Optional: Missing test coverage
Edited by 🤖 GitLab Bot 🤖