Members of Groups Shared With An Empty Merge Approver Group See the Group Listed as Private in Merge Request Approvers List
Summary
Steps to reproduce
- Set up a group structure similar to the following where the group, its subgroups, and projects are all private.
graph TD;
A[Group]-->B[Shared Group];
A-->E[Approvers Group - Empty];
A-->C[Projects Group];
C-->D[Test Project];
- Add
User 1
directly toShared Group
. - Add
User 1
directly to theTest Project
. -
Share
Approvers Group - Empty
with theShared Group
. - Create a Merge Approval Rule in the
Test Project
and assignApprovers Group - Empty
to the rule. - Have
User 1
attempt to review/edit the approval rule and observe thatApprovers Group - Empty
will show asPrivate
despite having access toApprovers Group - Empty
via Group Share.
NOTE: Adding a project to Approvers Group - Empty
will resolve the issue.
Example Project
What is the current bug behavior?
Users with shared access to a Merge Request Approval Group see the group listed as Private Group(s)
in the approvers list.
What is the expected correct behavior?
Users with shared access to a Merge Request Approval Group should see the group in the approvers list as they have access to the group.
Relevant logs and/or screenshots
Screenshots:
Approvers Group - Empty
Group
Empty
Approvers Group - Empty
Group
After Adding a Project to the
Output of checks
This bug happens on GitLab.com
Edited by Ryan Kelly