Danger bot feature category parsing doesn't support multiline definitions
Summary
When needing to split the RSpec.describe
definition into multiple lines to be under the line length limit (currently 120
chars) the REGEX that danger uses will not find the definition of the feature category
Steps to reproduce
- Set feature_category in multiline
RSpec.describe
definition ( e.g. !98438 (comment 1203159494) ) - See false positive bot comments
Example Project
https://gitlab.com/gitlab-org/gitlab/
What is the current bug behavior?
Danger reports a .describe
block as not having a feature_category even when there is one present, false positive.
What is the expected correct behavior?
It should parse the file in a way that accepts multiline definitions of arguments to the .describe
block.
Relevant logs and/or screenshots
Possible fixes
Parse the example with Ruby and query the metadata of the example if it has the feature_category
set.