Further encrypt connection details with Analytics Stack integration
As part of the Analytics Stack integration, we set up a few connection details in Admin Settings with regards to Cube, Clickhouse, and Jitsu:
We encrypt the Jitsu administrator password
, but don't for the Jitsu administrator email
and Clickhouse URL
, which contains a user:pass
in the DSN value in plain text.
Proposal
After a discussion with @alexives, he suggested it makes sense to create a new column and delete the old one rather than rename the existing column.
- Create migration to create a new column.
clickhouse_connection_string_secret
andclickhouse_connection_string_secret_iv
as defined in our docs: https://docs.gitlab.com/ee/development/migration_style_guide.html#encrypted-attributes - Create migration to migrate old column to new one.
- Ignore, and begin to remove old
clickhouse_connection_string
column. (Multi-milestone process of removal.)
Edited by Max Woolf