Commit Detail page should display the first not-skipped pipeline
Release notes
-
Bugfix: the pipeline status icon in the "branches" view selects the most recent pipeline from the commit and the branch. (previously, the icon might show pipelines that have run from other branches)
-
Feature: The commit detail page shows the most recent non-skipped pipeline executed from this commit from any branch. This is changed to exclude pipelines that have been skipped, if there is at least one non-skipped pipeline.
Problem to solve
Users need to see at a glance whether a commit "is good", e.g. its pipelines are not failing. Skipped pipelines do not provide any insight to this, and should be skipped (pun intended...) in choosing from what pipeline the status icon will be shown.
I've set up a public repository to demonstrate the issue. There is one commit that is both on the tip of the main
and otherbranch
branches. The push to otherbranch
had -o ci.skip
.
Oh... the branch list at https://gitlab.com/handig-eekhoorn/gitlab-test-ci-skip/-/branches is already wrong! I'd suspect the main
branch's icon to refer to the pipeline executed on main
(https://gitlab.com/handig-eekhoorn/gitlab-test-ci-skip/-/pipelines/708658088), but actually it refers to the most recent pipeline of the commit, which is https://gitlab.com/handig-eekhoorn/gitlab-test-ci-skip/-/pipelines/708658516 and was skipped.
Branch list | Pipelines with the same commit |
---|---|
For the commits, on the Commits list it shows the pipeline status as passed
. However for the commit detail page (e.g. handig-eekhoorn/gitlab-test-ci-skip@997787c5 ), it is a skipped
status instead of "passed".
Commit list | Commit detail |
---|---|
Proposal
- For
Branches
list, display the pipeline status of the most recent pipeline for the branch -
For(this is what the system already does so it does not need to be changed)Commits
list, display the pipeline status of the most recent pipeline for the selected branch