Dropdowns style regression

Summary

This commit seems to have introduced a regression in dropdowns styling. The icon that indicates the selected item overlaps the item's text.

Here's the MR associated to that commit: !20176 (commits)

Steps to reproduce

Pull the current master and open the dropdown next to the issue search box in any project.

Example Project

Any project

What is the current bug behavior?

image

What is the expected correct behavior?

This is what I see when I git revert de558678bb2dd09411fef181e040f65b4d4ce6b4 (de558678):

image

Possible fixes

The culprit seems to be selector change in app/assets/stylesheets/framework/dropdowns.scss: !20176 (diffs)

-    a,
+    a:not(.help-link),
Edited Dec 06, 2019 by Paul Gascou-Vaillancourt
Assignee Loading
Time tracking Loading