Update dashboards_enabled! to check for the settings
Problem to solve
If a user visits /-/product_analytics/dashboards
without having the admin settings filled in, we render the dashboard app even though it won't work without the settings.
Proposal
Check that all the settings have been set before returning true
on dashboards_enabled!
.
Implementation plan
- Check for the existence of the settings in
dashboards_enabled!
Gitlab::CurrentSettings.jitsu_host
Gitlab::CurrentSettings.jitsu_project_xid
Gitlab::CurrentSettings.jitsu_administrator_email
Gitlab::CurrentSettings.jitsu_administrator_password
Gitlab::CurrentSettings.clickhouse_connection_string
Gitlab::CurrentSettings.cube_api_base_url
Gitlab::CurrentSettings.cube_api_key
- Update specs to check this new requirement
Edited by Robert Hunt