Simplify the signing commits popover
With !97248 (merged) it's possible to sign commits using SSH keys. It's an opportunity to simplify the popover. (@mle thanks for the proposal!)
- The check icon is larger than the icon size of 16x16 (https://gitlab-org.gitlab.io/gitlab-svgs/?q=\~check-sm)
- Recommendation: Remove the icon
- The word verified is used twice in this sentence but it is unclear why the "verified signature" is in bold.
- Recommendation: Use the popover title for using bold
- Commiter name and avatar is being displayed but this is the same as the avatar and name on the left
- Recommendation: Remove the avatar and user details
- The sentence wraps on two lines and could be rephrased to fit one line
- Recommendation: Remove the word "more" and add a
.
to the sentence.
- Recommendation: Remove the word "more" and add a
-
Verified
badge does not match the badge styling for Pajamas.- Recommendation: Use Pajamas badge styling which is looks more like a pill
- Variant:
Success
-
Unverified
badge does not match the badge styling for Pajamas.- Recommendation: Use Pajamas badge styling
- Variant:
Neutral muted
- The key label and key value should have
word-break: normal
and the key value should haveword-break: break-all
so that it can wrap
Proposed design
Current design | Proposed design |
---|---|
![]() |
![]() |
States of the popover
Click on image to leave feedback
Edited by Michael Le