Skip to content
GitLab
Next
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 51,948
    • Issues 51,948
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,581
    • Merge requests 1,581
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLabGitLab
  • Issues
  • #382997
Closed
Open
Issue created Nov 16, 2022 by Daniel Tian@dftianDeveloper

[Feature flag cleanup] Block merging if there are failed status checks

Summary

This issue is to cleanup the only_allow_merge_if_all_status_checks_passed feature flag, after the feature flag has been enabled by default for an appropriate amount of time in production.

Owners

  • Team: groupcompliance
  • Most appropriate slack channel to reach out to: #g_manage_compliance
  • Best individual to reach out to: @dftian
  • PM: @stkerr

Stakeholders

Expectations

What might happen if this goes wrong?

Cleaning up the feature flag

  • Create a merge request to remove only_allow_merge_if_all_status_checks_passed feature flag. Ask for review and merge it.
    • Remove all references to the feature flag from the codebase.
    • Remove the YAML definitions for the feature from the repository.
    • Create a changelog entry.
  • Ensure that the cleanup MR has been deployed to both production and canary. If the merge request was deployed before the code cutoff, the feature can be officially announced in a release blog post.
    • /chatops run auto_deploy status 00693c880db0c069124029f6b075ac2bc5611b1e
  • Close the feature issue to indicate the feature will be released in the current milestone.
  • If not already done, clean up the feature flag from all environments by running these chatops command in #production channel:
    • /chatops run feature delete only_allow_merge_if_all_status_checks_passed --dev
    • /chatops run feature delete only_allow_merge_if_all_status_checks_passed --staging
    • /chatops run feature delete only_allow_merge_if_all_status_checks_passed
  • Close this rollout issue.

This page may contain information related to upcoming products, features and functionality. It is important to note that the information presented is for informational purposes only, so please do not rely on the information for purchasing or planning purposes. Just like with all projects, the items mentioned on the page are subject to change or delay, and the development, release, and timing of any products, features, or functionality remain at the sole discretion of GitLab Inc.

Edited Feb 12, 2023 by Elwyn Benson
Assignee
Assign to
Time tracking