Update definitions to use feature_category
Follow up from discussion &8383 (comment 1158471791) and !100024 (comment 1133728812)
The one suggestion I'll add, unrelated to this MR, instead of using
group
, usefeature_category
. Feature categories map directly to groups, but groups are more likely to change. Say, using this example,project management
was split into two groups, one focused on team planning, and one focused on planning analyitcs, we'd probably want this to stay with the group assigned team planning. If we have thegroup
designation in here, that's one more thing that has to be updated if groups change.https://about.gitlab.com/handbook/product/categories/#categories-a-z
We use this same tactic for categorizing usage data, database tables, and api endpoints.
Implementation Plan
- Update
config/audit_events/types/type_schema.json
and replace thegroup
field withfeature_category
. Update the RSpecs for the schema. - Update all the existing YML definitions inside the directories
config/audit_events/types
andee/config/audit_events/types
and replacegroup
with an appropriatefeature_category
, we'll probably have to ask the respective groups to suggest the correct feature category for that particular audit event type. - Update the
bin/audit-event
CLI to ask forfeature_category
as the input instead ofgroup
. Update RSpecs for the CLI.
Edited by Huzaifa Iftikhar