Remove unnecessary duplication of variables and rely on gitlab-ui
Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.
Follow-up from "GitLab UI integration branch for 1452-tint-neutral-palette"
Problem to solve
We currently duplicate some of our gitlab-ui variables in the GitLab project. From what I can tell, this is because we reference some of these variables from within the variables.scss file and gitlab-ui isn't pulled in and available ahead of this (see here).
This was discussed a bit in !102565 (comment 1161003487):
we don't pull in gitlab-ui ahead of this file
We might be able to
@import '@gitlab/ui/src/scss/variables';at the very top of our main stylesheet so that we immediately have access to those variables without revisiting the whole imports order. As always with CSS, we'll have to be very cautious with this kind of change😅
Proposal
TBD