Designs tab: Deleting a design doesn't actually delete

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Close this issue

One big problem with how we set up versioning of the design "batch" is that when someone deletes a design, it doesn't actually delete it. You can go to a previous version to see the deleted design, which could be a problem for someone who might accidentally put up something confidential (or worse).

I've also gathered feedback around the confusing nature of the versioning of design batches. I understand this is what's happening under the hood, but I'm not sure how much value we're getting out of viewing older and newer versions of design batches. All we really get out of them is what's been added/modified/deleted, but you still need to look at the design itself to be able to see what was modified.

This is probably related to #37296 (closed) in how we use Git to handle design management.

Proposal

• Rename existing deleted state to archived.
• Actually delete designs permanently (which is what someone expects when they delete something)

Permissions and Security

• If you can add/update a design, you should also be able to delete/archive a design.

Availability & Testing

1. Unit tests of DesignsFinder.
2. Unit tests of GraphQL mutation (including errors, input validation, authorization).
3. Migration test for the renamed state.

Merge request breakdown

backend:

Has been split into three four implementation issues:

• DesignManagement::Action.event enum
• Migration and scopes
• Services
• GraphQL

See also:

• #217542 (closed)
• #217543 (closed)

frontend:

1. Rename Delete to Archive (both in the UI and the mutation).
2. Add new Delete mutation and UI action.

See design in designs tab

Documentation

@toupeira:

• Highlight that the previous "Delete" was renamed to "Archive".

Prototype

https://sketch.cloud/s/GxoOL/a/ZDL8E3/play. Sketch cloud now has an inspector!

cc @andr3 @alexkalderimis @.luke @ntepluhina @cdybenko