job startup-css-check fails (related to .logged-out-marketing-header)
Examples
- https://gitlab.com/gitlab-org/gitlab/-/jobs/3229965853
- https://gitlab.com/gitlab-org/gitlab/-/jobs/3229741881
Stacktrace
$ yarn check:startup_css
==> 'yarn generate:startup_css' succeeded in 4 seconds.
yarn run v1.22.17
$ scripts/frontend/startup_css/startup_css_changed.sh
-----------------------------------------------------------
If you run into any issues with Startup CSS generation
please check out the feedback issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/331812
-----------------------------------------------------------
Staging changes to '*app/assets/stylesheets/startup*' so we can check for untracked files...
Startup CSS changes detected!
It looks like there have been recent changes which require
regenerating the Startup CSS files.
IMPORTANT:
- If you are making changes to any Startup CSS file, it is very likely that
**both** the CE and EE Startup CSS files will need to be updated.
- Changing any Startup CSS file will trigger the "as-if-foss" job to also run.
HOW TO FIX:
To fix this job, consider one of the following options:
1. (Strongly recommended) Copy and apply the diff below:
2. Regenerate locally with "yarn run generate:startup_css".
You may need to set "FOSS_ONLY=1" if you are trying to generate for CE.
----- start diff -----
diff --git a/ee/app/assets/stylesheets/startup/startup-general.scss b/ee/app/assets/stylesheets/startup/startup-general.scss
index 802262ba3..28c2952f6 100644
--- a/ee/app/assets/stylesheets/startup/startup-general.scss
+++ b/ee/app/assets/stylesheets/startup/startup-general.scss
@@ -584,11 +584,6 @@ svg {
html {
overflow-y: scroll;
}
-@media (min-width: 576px) {
- .logged-out-marketing-header {
- --header-height: 72px;
- }
-}
.btn {
border-radius: 4px;
font-size: 0.875rem;
----- end diff -------
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Cleaning up project directory and file based variables
00:01
ERROR: Job failed: exit code 1
Edited by David Dieulivol