New sign-in page has hardcoded Terms of Service text with non-existent URL if no terms are set
Summary
The redesign of the login page (!91673 (merged)) added a hardcoded text for accepting the Terms of service with an URL to https://gitlab-host/-/users/terms.
In a self-hosted environment where login is required for all users and no terms of agreement are set, the link leads nowhere, only back to the login page.
By signing in you accept the Terms of Use and acknowledge the Privacy Policy and Cookie Policy.
Additionally the text implies that the Terms of Use are accepted by logging in instead of actively confirming them, which might confuse users if they actually have to actively confirm.
Steps to reproduce
- use a self-hosted gitlab instance (Version 15.4.2)
- remove privacy policy (if possible, I could not remove the policy under "Admin>Settings>General>Terms of Service and Privacy" after adding one for testing)
- navigate to the login page in a logged out state
- click on the "Privacy and Cookie Policy" link.
Example Project
n/a
What is the current bug behavior?
When clicking on the link the user is routed back to the login page.
(Additionally the privacy policy cannot be removed, the last string is saved when removing all text from the textbox and clicking "Save changes", but this is not the main concern of this issue)
What is the expected correct behavior?
When no privacy policy is set, the text and the link should not be shown or the text and link should be at least customizable.
(The privacy policy should be removable.)
Relevant logs and/or screenshots
Output of checks
Results of GitLab environment info
Results of GitLab application Check
Possible fixes
This is the hardcoded text: f66a2c73