Skip to content
GitLab
Next
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • GitLab GitLab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 52,609
    • Issues 52,609
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1,545
    • Merge requests 1,545
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLabGitLab
  • Issues
  • #378447
Closed
Open
Issue created Oct 19, 2022 by Andrew Fontaine@afontaineMaintainer

Alert users that they can still make unified approval rules via the API

Problem

Once the settings UI for Protected Environments utilizes multiple approval rules, we need to alert users that they can still utilize unified approval rules, but by API only.

Proposal

Update the frontend to display an alert that users can still use the API to configure their unified approval rules

Designs:

Flow for protecting an environment:

Flow with Banner:

For one milestone after this launches, we provide users with a banner letting them know where unified approval rules went and more information about multiple approval rules. After this milestone passes, we remove the banner and move the information to the approval rules help text.

Banner
Screen_Shot_2022-10-19_at_8.42.10_AM
  • API: https://docs.gitlab.com/ee/ci/environments/deployment_approvals.html#unified-approval-setting
  • Multiple Approval Rules: https://docs.gitlab.com/ee/ci/environments/deployment_approvals.html#multiple-approval-rules

Technical Proposal

  1. Pass links to multiple approval rules docs and API docs via the vue app mount point
  2. Use the gitlab alert component to display the text and links
  3. make sure the alert is dismissible, but we do not need to persist this dismissal to the backend. The alert should come back on page load

This page may contain information related to upcoming products, features and functionality. It is important to note that the information presented is for informational purposes only, so please do not rely on the information for purchasing or planning purposes. Just like with all projects, the items mentioned on the page are subject to change or delay, and the development, release, and timing of any products, features, or functionality remain at the sole discretion of GitLab Inc.

Edited Oct 21, 2022 by Andrew Fontaine
Assignee
Assign to
Time tracking