GitLab Version - Address Nested Links in Help Dropdown
What / Why
Follow up from @eduardosanz thread here: !100978 (comment 1137873160)
The GitLab Version Badge located in the Help Dropdown actually renders as an <a>
nested inside of an <a>
. This is incorrect markup and additionally may cause issues with the tracking events.
Proposal
- Implement an
actionable
prop toGitlabVersionCheck
- Only make
GlBadge
actionable if prop is true - Set
GitlabVersionCheck
in help dropdown toactionable: false
- Add a separate tracking event when the version check help dropdown link itself is clicked (similar to the other help dropdown links).