Reconcile the differences between numberToHumanSize and number_to_human_size (KB vs KiB, significant digits)

Everyone can contribute. Help move this issue forward while earning points, leveling up and collecting rewards.

• Close this issue

The following discussion from !99198 (merged) should be addressed:

• @mkozono started a discussion:

  nitpick (non-blocking): There is a preexisting typo precicion => precision.

  Apparently precision defaults to 3 and significant defaults to true, therefore the preexisting behavior is actually "3 significant digits". Do we just want this?

      = number_to_human_size(@total_size)

  question (non-blocking): There seem to be a number of self-contradictions and differences with number_to_human_size in numberToHumanSize. WDYT about a follow up issue/MR to reconcile them?

  For example if I'm reading it right, Rails outputs 12.1 KB, while the JS outputs 12.10 KiB.

  https://api.rubyonrails.org/classes/ActionView/Helpers/NumberHelper.html#method-i-number_to_human_size

  https://gitlab.com/gitlab-org/gitlab/-/blob/830254d78142c70d7b9605cb872cbd5d5202d396/app/assets/javascripts/lib/utils/number_utils.js#L75