Remove assertion that delete_refs with \\ in refname raises Gitlab::Git::Repository::GitError
In gitaly!4921 (merged), Gitaly
will learn to validate ref formats with a backslash \ in it. Currently,
this case falls through to the git update-ref
prepare
stage, which
gets sent back as a GitError.
Once the Gitaly MR gets merged, Gitaly will catch the case when backslashes are
in the refname and return a structured error that will get caught in ref_service.rb
which will raise a Gitlab::Git::InvalidRefFormatError
.
!100605 (merged) added a compound
assertion to expect both types of errors. Once the Gitaly MR is merged and
GITALY_SERVER_VERSION
includes the change, we can remove the assertion of Gitlab::Git::Repository::GitError
Edited by John Cai