GitHub Import: move pull request workers and importers under namespace
Problem
Currently, GitHub importer has a mixed structure in terms of file placement. Some of the importers/workers are under namespace, and some are located in the root directory.
Proposal
- As it is stated in the documentation worker class removal should be done in two steps.
In %16.0 the following workers are planned to be moved
ImportPullRequestMergedByWorker: app/workers/gitlab/github_import/import_pull_request_merged_by_worker.rb
change it's location to app/workers/gitlab/github_import/pull_requests/import_merged_by_worker.rb
.
ImportPullRequestReviewWorker: app/workers/gitlab/github_import/import_pull_request_review_worker.rb
change it's location to app/workers/gitlab/github_import/pull_requests/import_review_worker.rb
.
- Since importers that are used by workers follow the same rules in terms of structure/namespacing it makes sense to move importers as well to be consistent all over GitHub importer.
PullRequestMergedByImporter: lib/gitlab/github_import/importer/pull_request_merged_by_importer.rb
move to lib/gitlab/github_import/importer/pull_requests/merged_by_importer.rb
PullRequestsMergedByImporter: lib/gitlab/github_import/importer/pull_requests_merged_by_importer.rb
move to lib/gitlab/github_import/importer/pull_requests/all_merged_by_importer.rb
(changes it's name since merged_by is not pluralisable)
PullRequestsReviewsImporter: lib/gitlab/github_import/importer/pull_requests_reviews_importer.rb
move to lib/gitlab/github_import/importer/pull_requests/reviews_importer.rb
PullRequestReviewImporter: lib/gitlab/github_import/importer/pull_request_review_importer.rb
move to lib/gitlab/github_import/importer/pull_requests/review_importer.rb